Homec4science

Validate select/option settings more strictly when reading them

Authored by epriestley <git@epriestley.com> on Jun 5 2016, 19:23.

Description

Validate select/option settings more strictly when reading them

Summary:
Ref T4103. If the database has "" (empty string) for select/option settings, we can let that value be effective in the UI right now.

One consequence is that timestamps can vanish from the UI.

Instead, be stricter and discard it as an invalid value.

Test Plan:

  • Forced time-format setting to ''.
  • Saw timestamps vanish before change.
  • Saw timestamps return to the default value after change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16047

Details

Committed
epriestley <git@epriestley.com>Jun 5 2016, 19:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4de87a07ab0: Improve some settings-related performance
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc9ef7aeaa34a: Validate select/option settings more strictly when reading them (authored by epriestley <git@epriestley.com>).Jun 5 2016, 19:32