Homec4science

Slightly improve UTF-8 handling in Differential

Authored by epriestley <git@epriestley.com> on Jun 23 2011, 21:01.

Description

Slightly improve UTF-8 handling in Differential

Summary:
See comments. I think this will fix the issue, where we end up handling off
garbage to htmlspecialchars() after highlighting a file we've stuck full of \0
bytes.

The right fix for this is to make wordwrap and intraline-diff utf8 aware and
throw this whole thing away. I'll work on that but I think this fixes the
immediate issue.

Test Plan:
diffed the file with a UTF-8 quote in it and got a reasonable render in
Differential

Reviewed By: jungejason
Reviewers: jungejason, aran, tuomaspelkonen
CC: aran, jungejason
Differential Revision: 504

Details

Committed
epriestley <git@epriestley.com>Jun 23 2011, 21:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb093113d0227: Fix fatal on project editing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd031d3ae329b: Slightly improve UTF-8 handling in Differential (authored by epriestley <git@epriestley.com>).Jun 23 2011, 21:28