Homec4science

Minor consistency/order updates for menu items which reference other objects

Authored by epriestley <git@epriestley.com> on Jan 20 2017, 20:42.

Description

Minor consistency/order updates for menu items which reference other objects

Summary:
See T11957#208140.

  • Let Applications have a custom name, like other object items (for example, so you can call Maniphest "Tasks" if you prefer).
  • Put the optional name field after the required typeahead field for these items.
    • (I left "Link" in "Name, URI" order since both are required, but there's maybe an argument for swapping them?)

Test Plan:

  • Created each type of item, saw "thing, name" order.
  • Created an application with a cusotm name, saw custom name.
  • Removed custom name, saw original name.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17236

Details

Committed
epriestley <git@epriestley.com>Jan 20 2017, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8113b7691089: Validate menu item fields (links, projects, dashboards, applications, forms…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd24739ee3cfa: Minor consistency/order updates for menu items which reference other objects (authored by epriestley <git@epriestley.com>).Jan 20 2017, 20:58