Homec4science

Disable Herald more aggressively when it's turned off for a repository

Authored by epriestley <git@epriestley.com> on Mar 13 2014, 02:16.

Description

Disable Herald more aggressively when it's turned off for a repository

Summary:
Currently, disabling Herald only disables feed, notifications and email. Historically, audits didn't really create external effects so it made sense for Herald to only partially disable itself.

With the advent of Harbormaster/Build Plans, it makes more sense for Herald to just stop doing anything. When this option is disabled, stop all audit/build/publish/feed/email actions for the repository.

Test Plan: Ran scripts/repository/reparse.php --herald, etc.

Reviewers: dctrwatson, btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8509

Details

Committed
epriestley <git@epriestley.com>Mar 13 2014, 02:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8a409aa40fe0: Fix parsing of "Reviewed By" field
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd27cd5fb9902: Disable Herald more aggressively when it's turned off for a repository (authored by epriestley <git@epriestley.com>).Mar 13 2014, 02:16