Homec4science

Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if…

Authored by epriestley <git@epriestley.com> on Jan 21 2016, 21:59.

Description

Make bin/storage upgrade and bin/storage adjust emit detailed messages if the user has no access to databases

Summary:
Ref T10195. Distinguish between "database does not exist" and "database exists, you just don't have permission to access it".

We can't easily get this information out of INFORMATION_SCHEMA but can just SHOW TABLES IN ... every database that looks like it's missing and then look at the error code.

Test Plan:

  • Created a user limited with limited access.
  • Ran bin/storage adjust.
  • Got hopefully more helpful messages about access problems, instead of "Missing" errors.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10195

Differential Revision: https://secure.phabricator.com/D15079

Details

Committed
epriestley <git@epriestley.com>Jan 21 2016, 22:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7bf4ef451b3f: Make herald tokenizers copy values more correctly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd37153f00304: Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if… (authored by epriestley <git@epriestley.com>).Jan 21 2016, 22:06