Homec4science

Use OpaqueEnvelopes for all passwords in Phabricator

Authored by epriestley <git@epriestley.com> on Jul 17 2012, 21:06.

Description

Use OpaqueEnvelopes for all passwords in Phabricator

Summary:
See D2991 / T1526. Two major changes here:

  • PHP just straight-up logs passwords on ldap_bind() failures. Suppress that with "@" and keep them out of DarkConsole by enabling discard mode.
  • Use PhutilOpaqueEnvelope whenever we send a password into a call stack.

Test Plan:

  • Created a new account.
  • Reset password.
  • Changed password.
  • Logged in with valid password.
  • Tried to login with bad password.
  • Changed password via accountadmin.
  • Hit various LDAP errors and made sure nothing appears in the logs.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2993

Details

Committed
epriestley <git@epriestley.com>Jul 17 2012, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHae2e73ce809f: Add "stop on redirect" and "always profile" debugging options
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdd70c5946505: Use OpaqueEnvelopes for all passwords in Phabricator (authored by epriestley <git@epriestley.com>).Jul 17 2012, 21:06