Homec4science

Conduit - Add option for createcomment to attach draft inline comments

Authored by Joel Beales <joelb@fb.com> on Sep 18 2013, 02:11.

Description

Conduit - Add option for createcomment to attach draft inline comments

Summary:
Conduit has a query to make a draft inline comment, but createcomment doesn't have the ability to attach them.
Added optional parameter to attach any existing draft comments. Default value is false, so existing api users won't be effected by the change.

Test Plan: Tested no draft comments and multiple draft comments, attach_inlines =true, false, and empty.

Reviewers: vrana

Reviewed By: vrana

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D7019

Details

Committed
Joel Beales <joelb@fb.com>Sep 18 2013, 19:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH209edcd75a93: Fix two minor Differential issues
Branches
Unknown
Tags
Unknown

Event Timeline

Joel Beales <joelb@fb.com> committed rPHdf8474d77804: Conduit - Add option for createcomment to attach draft inline comments (authored by Joel Beales <joelb@fb.com>).Sep 18 2013, 19:03