Homec4science

Improve Differential handling of disabled users

Authored by epriestley <git@epriestley.com> on Jan 17 2012, 01:54.

Description

Improve Differential handling of disabled users

Summary:
We currently allow you to assign code review to disabled users, but
should not.

Test Plan:

  • Created revisions with no reviewers and only disabled reviewers, was

appropriately warned.

  • Looked at a disabled user handle link, was clearly informed.
  • Tried to create a new revision with a disabled reviewer, was rebuffed.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D1429

Details

Committed
epriestley <git@epriestley.com>Jan 17 2012, 18:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4faab06c3c76: Enable herald rule for commits that need auditing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe2c75d5dc214: Improve Differential handling of disabled users (authored by epriestley <git@epriestley.com>).Jan 17 2012, 18:27