Homec4science

Improve STRICT_ALL_TABLES warning

Authored by epriestley <git@epriestley.com> on Feb 6 2013, 22:37.

Description

Improve STRICT_ALL_TABLES warning

Summary:

  • Make the warning describe rationale and point at the MySQL manual explicitly.
  • Add a reference to the developer mode config, in case the user wants to resolve the probelm by disabling developer mode.
  • Now that the message is huge, provide a summary.
  • Move from "Database" to "MySQL" setup checks -- this is kind of arbitrary, but the former is used for fatals (pre-install) and the latter for warnings (post-install) right now. This has no practical impact on anything and is purely stylistic.

Test Plan:
{F31798}

{F31799}

Reviewers: edward, blc

Reviewed By: edward

CC: aran

Differential Revision: https://secure.phabricator.com/D4835

Details

Committed
epriestley <git@epriestley.com>Feb 6 2013, 22:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPH84efcb86698a: Minor, fix an issue with PhabricatorMenuView and default null keys.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe518135dfb54: Improve STRICT_ALL_TABLES warning (authored by epriestley <git@epriestley.com>).Feb 6 2013, 22:37