Homec4science

Fix some issues with the "Explain Why" dialog

Authored by epriestley <git@epriestley.com> on May 30 2016, 18:09.

Description

Fix some issues with the "Explain Why" dialog

Summary:
Ref T11051. This is still not as clear as it should be, but is at least working as intended now.

I believe this part of the code just never worked. The test plan on D10489 didn't specifically cover it.

Test Plan:
Did this sort of thing in a repository:

$ git checkout -b featurex
$ echo x >> y
$ git commit -am wip
$ arc diff

Then I simulated just pushing it (this flow is a little more involved than necessary):

$ arc land --hold
$ git commit --amend
$ # remove all metadata -- particularly, "Differential Revision"!
$ git push HEAD:master

I got a not-great but more-useful dialog:

{F1667318}

Prior to this change, the hash match was incorrectly not reported at all.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11051

Differential Revision: https://secure.phabricator.com/D15989

Details

Committed
epriestley <git@epriestley.com>May 30 2016, 18:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb352cae97de4: Don't stop on read-only mode for read-only storage workflows
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe81637a6c686: Fix some issues with the "Explain Why" dialog (authored by epriestley <git@epriestley.com>).May 30 2016, 18:52