Homec4science

Make translation, timezone and pronoun into real settings

Authored by epriestley <git@epriestley.com> on Jun 2 2016, 01:17.

Description

Make translation, timezone and pronoun into real settings

Summary:
Ref T4103. These are currently stored on the user, for historic/performance reasons.

Since I want administrators to be able to set defaults for translations and timezones at a minimum and there's no longer a meaningful performance penalty for moving them off the user record, turn them into real preferences and then nuke the columns.

Test Plan:

  • Set settings to unusual values.
  • Ran migrations.
  • Verified my unusual settings survived.
  • Created a new user.
  • Edited all settings with old and new UIs.
  • Reconciled client/server timezone disagreement.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16005

Details

Committed
epriestley <git@epriestley.com>Jun 2 2016, 15:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHedfc6a69345a: Convert some loadPreferences() to getUserSetting()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHebd8f3c9874b: Make translation, timezone and pronoun into real settings (authored by epriestley <git@epriestley.com>).Jun 2 2016, 15:29