Homec4science

Remove calls to getCallsign() in bin/repository scripts

Authored by epriestley <git@epriestley.com> on Jan 2 2016, 03:39.

Description

Remove calls to getCallsign() in bin/repository scripts

Summary:
Ref T4245. Prepare these scripts for a callsign-free world. This also makes them more flexible and easier to use.

The following are now valid ways to identify a repository for these scripts: ID (3), PHID (PHID-REPO-wxyz), R<ID> (R3), r<CALLSIGN> (rSKYNET), CALLSIGN (SKYNET).

In the future, a human-readable label (skynet) may also become valid.

Test Plan:

  • Ran bin/repository reparse --all ... with rX, X, 3, R3.
  • Ran bin/repository reparse --change ... with rXaaa, including short versions.
  • Ran bin/repository update ... with rX, X, 3, R3.
  • Ran bin/repository refs ... with various identifiers.
  • Ran bin/repository pull ... with various identifiers.
  • Ran bin/repository mirror ... with various identifiers.
  • Ran bin/repository mark-imported ... with various identifiers.
  • Ran bin/repository list.
  • Ran bin/repository importing ... with various identifiers and examined output.
  • Ran bin/repository edit ... with various identifiers.
  • Ran bin/repository discover ... with various identifiers.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D14924

Details

Committed
epriestley <git@epriestley.com>Jan 2 2016, 13:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPHff1bfb64dd56: Reduce the total number of calls to getCallsign()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHedcc3232aabc: Remove calls to getCallsign() in bin/repository scripts (authored by epriestley <git@epriestley.com>).Jan 2 2016, 13:23