Improve Asana API error handling in Doorkeeper
fca534d6b68a
Actions

Authored by epriestley <git@epriestley.com> on Jul 16 2013, 19:29.

Description

Improve Asana API error handling in Doorkeeper

Summary:
Ref T2852. We need to distinguish between an API call which worked but got back nothing (404) and an API call which failed.

In particular, Asana hit a sync issue which was likely the result of treating a 500 (or some other error) as a 404.

Also clean up a couple small things.

Test Plan: Ran syncs against deleted tasks and saw successful syncs of non-tasks, and simulated random failures and saw them get handled correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Committed

epriestley <git@epriestley.com>

Jul 16 2013, 19:29

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHfca534d6b68a: Improve Asana API error handling in Doorkeeper (authored by epriestley <git@epriestley.com>).Jul 16 2013, 19:29

				Path
	M			src/applications/differential/query/DifferentialRevisionQuery.php
	M			src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php
	M			src/applications/doorkeeper/engine/DoorkeeperObjectRef.php
	M			src/applications/doorkeeper/worker/DoorkeeperFeedWorkerAsana.php