Homec4science

fix differential + diffusion for showing generated files

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 19 2012, 19:56.

Description

fix differential + diffusion for showing generated files

Summary: in the re-factor quest this got broken. Turns out NewLines (aka $this->new in the parser) gets updated right up until the very end for showing text changes so instead pass over the total line count to the renderer to get this codepath right.

Test Plan: showed content of some generated files in diffusion and all was well

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2204

Differential Revision: https://secure.phabricator.com/D4237

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Dec 19 2012, 19:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb8d372c4bc3e: Fix bugs when saving package changes due to commit changes
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHfcc5366effa4: fix differential + diffusion for showing generated files (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 19 2012, 19:56