Diffusion Phabricator (stable) History

DifferentialTransactionEditor.php
stable98cec5d87a5a248e2f5712d…

May 17 2017

Merge with Stable Week 19 + patches to 73ed316c5d2e
98cec5d87a5a
·aubort on May 17 2017, 17:33.

May 2 2017

Merge with Stable Week 17
cef2e9b5c83c
·aubort on May 2 2017, 12:15.

Mar 27 2017

Merge with Stable Week 12
18d67dfe4c47
·aubort on Mar 27 2017, 13:03.

Jan 10 2017

Provide tailored strings for revision creation
00e2755eab62
·epriestley on Jan 10 2017, 21:45.

Jan 5 2017

Fix a case where "Accept + Comment" would ignore the "Accept"
1f2306999bb5
·epriestley on Jan 5 2017, 20:30.

Dec 31 2016

Make marking comments as "Done" work cleanly on EditEngine
69194fdaf510
·epriestley on Dec 31 2016, 19:12.
Restore some minor state behaviors to Differential on EditEngine
b373dcef7448
·epriestley on Dec 31 2016, 19:11.

Dec 13 2016

Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
77fa1ea73835
·epriestley on Dec 13 2016, 23:35.

Oct 18 2016

Make "metamta.differential.inline-patches" imply a reasonable byte limit, not…
dad17fb98a6b
·epriestley on Oct 18 2016, 00:56.

Sep 16 2016

When loading packages affected by a change to a particular path, ignore…
7f6fa283639f
·epriestley on Sep 16 2016, 23:02.

Aug 14 2016

Fix bad array index test in Differential package code
15021a0bcc91
·epriestley on Aug 14 2016, 22:10.

Jun 27 2016

Revision substate CLOSED_FROM_ACCEPTED
de6349dd67af
·Aviv Eyal / avivey on Jun 27 2016, 22:29.

Jun 13 2016

Don't re-mention users for comment edits
65634781b44f
·epriestley on Jun 13 2016, 22:57.

May 18 2016

Add a "View Revision" button to HTML email
5bb3cbe23922
·Chad Little on May 18 2016, 23:25.

May 17 2016

Allow users to manage package dominion rules
809c7bf996af
·epriestley on May 17 2016, 19:57.

May 14 2016

Don't trigger "Auto Review" if the author is already an owner; document "Auto…
c9365e48d8e4
·epriestley on May 14 2016, 02:24.
Support "Review Changes" and "Block Changes" settings for Owners package "Auto…
332d787dc8f4
·epriestley on May 14 2016, 02:22.
Implement "Auto Review" in packages with a "Subscribe" option
52ac242eb3b2
·epriestley on May 14 2016, 02:21.

May 12 2016

Improve HTML mail rendering of inline patches
bd9bcaa8ffea
·epriestley on May 12 2016, 21:13.

May 6 2016

Minor tweaks to pre/inline style for inline comments in HTML mail
371051ff3779
·epriestley on May 6 2016, 20:05.

May 5 2016

Highlight inline diff context in HTML mail
94c7bb605c35
·epriestley on May 5 2016, 20:13.
Rough cut of inline comment context
2025ecd3d826
·epriestley on May 5 2016, 18:23.

Nov 28 2015

Partially revert D14511 to fix "INLINE COMMENTS" in mail
0d01dab5a375
·epriestley on Nov 28 2015, 22:40.

Nov 23 2015

Render Remarkup in emails
2047483cc046
·Joshua Spence on Nov 23 2015, 20:43.

Nov 17 2015

Fix file PHID extraction in Owners and Differential
5aae89babb73
·epriestley on Nov 17 2015, 17:36.

Aug 3 2015

Modularize the Harbormaster "Run build plan" Herald action
776caa507b15
·epriestley on Aug 3 2015, 23:33.
Modularize the Legalpad "Require Signature" Herald Action
fdd379a026c3
·epriestley on Aug 3 2015, 23:33.
Modularize Differential Reviewer actions in Herald
a335004a91a9
·epriestley on Aug 3 2015, 23:33.

Jun 25 2015

Carefully avoid the harbormaster/differential race
db1bc7fd7f1f
·epriestley on Jun 25 2015, 19:05.

Jun 23 2015

Smooth out some UI/UX issues in Harbormaster
c31e25d5ceed
·epriestley on Jun 23 2015, 19:23.

Jun 8 2015

Use standard subscribers effects in Herald Adapter for revisions
9e88ede69d90
·epriestley on Jun 8 2015, 19:32.
Consolidate "Subscribers" Herald field value logic
623aaf488dc3
·epriestley on Jun 8 2015, 19:18.
Remove `*TransactionType` classes
5914bbd806e6
·Joshua Spence on Jun 8 2015, 03:26.

Jun 4 2015

Reload revisions before publishing mail about them
4a45620b0458
·epriestley on Jun 4 2015, 05:01.
Move all ApplicationTransaction publishing to daemons
a9ceebbdb116
·epriestley on Jun 4 2015, 03:59.

May 22 2015

phtize all the things
36e2d02d6ec5
·Joshua Spence on May 22 2015, 13:16.

May 20 2015

Transactions - fix bug adding people to projects
2154f17b3d7b
·Bob Trahan on May 20 2015, 00:22.

May 19 2015

Transactions - make implementing TYPE_XXXX_POLICY transactions optional
81a475d5a6b4
·Bob Trahan on May 19 2015, 21:58.
Transactions - make TYPE_COMMENT implementation optional
01a8ba5a9798
·Bob Trahan on May 19 2015, 21:33.
Transactions - move TYPE_SUBSCRIBERS to require optional implementation
18e0ee079132
·Bob Trahan on May 19 2015, 20:48.
Transactions - make customization of TYPE_EDGE optional
16c8d44c37c9
·Bob Trahan on May 19 2015, 20:26.

May 18 2015

Remove arcanist projects from differential
021223907dfd
·Joshua Spence on May 18 2015, 16:36.

Apr 6 2015

Allow "send me an email" in personal rules to punch through settings
b16db61a87f3
·epriestley on Apr 6 2015, 19:01.
Lift handling of Herald "email" effect to Adapter
a40748a46cb5
·epriestley on Apr 6 2015, 19:00.

Mar 26 2015

Move abandoned revisions to "needs review" when updated
cce6d06fa5ec
·epriestley on Mar 26 2015, 19:11.

Mar 24 2015

Lift inline comment state transactions into core (in Differential)
dd3afe2aa2ae
·epriestley on Mar 24 2015, 13:26.
Publish draft "done" status when submitting comments/updates/actions/inlines
9f3210c883b9
·epriestley on Mar 24 2015, 13:26.

Mar 23 2015

Throw a more helpful error for bad Differential actions
5001aadf4660
·epriestley on Mar 23 2015, 17:10.

Mar 9 2015

Write "hasReplies" to database for inline comments
2972894a4df9
·epriestley on Mar 9 2015, 22:11.

Jan 22 2015

Don't create mentions for dependent diffs
c429e4a22279
·Joshua Spence on Jan 22 2015, 21:12.

Jan 20 2015

Differential - return a better response for validation error cases
847ff549ceee
·Bob Trahan on Jan 20 2015, 22:59.

Jan 15 2015

Differential - re-jigger mail such that inline comments show up right after the…
57761ce2202a
·Bob Trahan on Jan 15 2015, 02:23.

Jan 3 2015

Modernize remaining edge types
7c2a7d03651c
·Joshua Spence on Jan 3 2015, 00:58.

Jan 1 2015

Migrate Differential revision edges to use modern `EdgeType` subclasses
7cab903943f5
·Joshua Spence on Jan 1 2015, 05:07.
Modernize Legalpad edge types
83d1e3edb59b
·Joshua Spence on Jan 1 2015, 01:15.

Dec 30 2014

Minor linter fixes
eedd7aa58bc4
·Joshua Spence / epriestley on Dec 30 2014, 11:48.

Nov 19 2014

Differential - refine selecting a repository diff --> revision workflow
7ef236c9a647
·Bob Trahan on Nov 19 2014, 20:11.
Differential - make DifferentialDiffEditor into a real transaction editor.
ffe0765b50c5
·Bob Trahan on Nov 19 2014, 00:32.

Oct 30 2014

Add addLinkSection to MailBody to properly format URIs
1ac84c1b59de
·Chad Little on Oct 30 2014, 23:24.

Sep 9 2014

Transactions - add infrastructure for "mentions"
c75495e63fa0
·Bob Trahan on Sep 9 2014, 23:21.
Apply some autofix linter rules
0151c38b107f
·Joshua Spence on Sep 9 2014, 22:55.

Aug 15 2014

Add an option to put comment context into emails.
eb3ed9bbc994
·Manuel Klimek / epriestley on Aug 15 2014, 19:14.
HTML emails
4c57e6d34d7a
·Tal Shiri / epriestley on Aug 15 2014, 17:12.

Aug 12 2014

Modularize mail tags
f6f9d78f3a07
·epriestley on Aug 12 2014, 21:28.

Aug 11 2014

Fix several issues with application interactions while importing commits
d38e89ef6ba5
·epriestley on Aug 11 2014, 21:08.

Jul 23 2014

Rename `PhabricatorApplication` subclasses
86c399b65783
·Joshua Spence on Jul 23 2014, 02:03.

Jul 18 2014

Modernize task/revision edges and write inverse transactions
533e799c5f7e
·epriestley on Jul 18 2014, 00:41.

Jun 29 2014

Allow Herald to "Require legal signatures" for reviews
add7bc418dcb
·epriestley on Jun 29 2014, 16:53.

Jun 10 2014

Applied various linter fixes.
d0128afa2908
·Joshua Spence / epriestley on Jun 10 2014, 01:04.

Jun 9 2014

Change double quotes to single quotes.
0a62f13464b8
·Joshua Spence / epriestley on Jun 9 2014, 20:36.

Jun 5 2014

Fix undefinded $changesets when submitting inline comments in Differential
ba2ce8a5ca1a
·epriestley on Jun 5 2014, 01:14.

Jun 4 2014

Introduce DifferentialChangesetQuery and remove loadHunks()
bb306b58d553
·epriestley on Jun 4 2014, 03:01.

Jun 3 2014

Expose "Abandon Revision" to non-authors with a config flag.
1e2a592ceb36
·Joshua Spence / epriestley on Jun 3 2014, 01:58.

Apr 19 2014

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"
71ef48b3e519
·epriestley on Apr 19 2014, 02:52.

Apr 11 2014

Differential - fix bug writing affected paths
cb675a46a24d
·Bob Trahan on Apr 11 2014, 21:54.

Apr 1 2014

Fix an issue where email for "accepted" revisions would fatal
ff98565db65e
·epriestley on Apr 1 2014, 22:35.
Restore "Branch" and "changes since last update" fields to Differential mail
cf6f7446ce3f
·epriestley on Apr 1 2014, 17:23.

Mar 25 2014

Downgrade accepts on "request changes", and make sticky accepts optional
ed2e12047af4
·epriestley on Mar 25 2014, 23:41.
Guarantee that fields copied from diffs persist on revisions
2547a222d8b1
·epriestley on Mar 25 2014, 22:01.

Mar 21 2014

Make Herald less ambitious about resolving repositories for revisions
03c6bf0d0916
·epriestley on Mar 21 2014, 22:39.

Mar 18 2014

Treat "request review" more like an update
1e8ed3e5ffc7
·epriestley on Mar 18 2014, 02:19.

Mar 14 2014

In Differential mail, hide "summary" if empty and show "test plan" if nonempty
efcca310c2cf
·epriestley on Mar 14 2014, 19:53.
Fix "Send an email to" Herald rule for Differential
b168ee116bd8
·epriestley on Mar 14 2014, 19:52.

Mar 12 2014

Fix two transactional issues around revision status
3b861ab7411d
·epriestley on Mar 12 2014, 23:24.
Minor, fix parameter passed to HarbormasterBuildable::applyBuildPlans()
08d013b391fc
·epriestley on Mar 12 2014, 20:13.
Restore old "author can not be a reviewer" rule to Transactions
9e3baacc95c2
·epriestley on Mar 12 2014, 14:04.
When creating a new revision, include the summary in the initial email
95285aee5034
·epriestley on Mar 12 2014, 01:13.

Mar 11 2014

Fix two minor Differential issues
0b15624c37e8
·epriestley on Mar 11 2014, 21:50.
Port Differential mail features forward to transactions
9e8bbdb3a2d4
·epriestley on Mar 11 2014, 21:02.
Perform derived index updates in TransactionEditor
c68703fbcb27
·epriestley on Mar 11 2014, 21:02.
Remove willWriteRevision/didWriteRevision hooks
a19f49632fd8
·epriestley on Mar 11 2014, 21:02.
Use DifferentialRevisionEditor in lipsum
fbaa12440eac
·epriestley on Mar 11 2014, 21:02.

Mar 8 2014

Fix Herald adapter construction for new revisions. Fixes T4572.
314edcabbb43
·epriestley on Mar 8 2014, 15:35.
Use TransactionEditor when closing revisions in response to commits
b04f706c0af6
·epriestley on Mar 8 2014, 02:43.

Mar 5 2014

Support Herald rules for new Differential edits
2ceffadee78a
·epriestley on Mar 5 2014, 21:07.
Add an explcit "Changes Planned" state for Differential
4ef87eeac832
·epriestley on Mar 5 2014, 19:47.
Make updates of rejected revisions behave correctly again
9da6ec208111
·epriestley on Mar 5 2014, 19:47.
Maniphest Tasks + Project Boards - some polish
e78df59ced7c
·Bob Trahan on Mar 5 2014, 02:01.

Mar 3 2014

Clean up some Differential behaviors
83206242c9dd
·epriestley on Mar 3 2014, 17:36.

Mar 1 2014

Make "EditPro" controller work with diff updates
bca0ad8fdd7f
·epriestley on Mar 1 2014, 01:49.

phab/src/applications/differential/editor/DifferentialTransactionEditor.phpstable98cec5d87a5a248e2f5712d…

May 17 2017

May 2 2017

Mar 27 2017

Jan 10 2017

Jan 5 2017

Dec 31 2016

Dec 13 2016

Oct 18 2016

Sep 16 2016

Aug 14 2016

Jun 27 2016

Jun 13 2016

May 18 2016

May 17 2016

May 14 2016

May 12 2016

May 6 2016

May 5 2016

Nov 28 2015

Nov 23 2015

Nov 17 2015

Aug 3 2015

Jun 25 2015

Jun 23 2015

Jun 8 2015

Jun 4 2015

May 22 2015

May 20 2015

May 19 2015

May 18 2015

Apr 6 2015

Mar 26 2015

Mar 24 2015

Mar 23 2015

Mar 9 2015

Jan 22 2015

Jan 20 2015

Jan 15 2015

Jan 3 2015

Jan 1 2015

Dec 30 2014

Nov 19 2014

Oct 30 2014

Sep 9 2014

Aug 15 2014

Aug 12 2014

Aug 11 2014

Jul 23 2014

Jul 18 2014

Jun 29 2014

Jun 10 2014

Jun 9 2014

Jun 5 2014

Jun 4 2014

Jun 3 2014

Apr 19 2014

Apr 11 2014

Apr 1 2014

Mar 25 2014

Mar 21 2014

Mar 18 2014

Mar 14 2014

Mar 12 2014

Mar 11 2014

Mar 8 2014

Mar 5 2014

Mar 3 2014

Mar 1 2014

phab/src/applications/differential/editor/DifferentialTransactionEditor.php
stable98cec5d87a5a248e2f5712d…